Fix reconditioned masks being overwritten during memory encoding Closes #531#533
Open
amier2775 wants to merge 1 commit intofacebookresearch:mainfrom
Open
Fix reconditioned masks being overwritten during memory encoding Closes #531#533amier2775 wants to merge 1 commit intofacebookresearch:mainfrom
amier2775 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
_recondition_masklets encodes detector masks into memory via propagate_in_video_preflight(run_mem_encoder=True), but the subsequent _tracker_update_memories call re-encodes the original tracker masks and overwrites the reconditioned memory for the same frame. Fix: replace reconditioned objects' masks in tracker_low_res_masks_global before _tracker_update_memories, so a single memory encoding pass uses the correct detector masks. Remove the now-unnecessary run_mem_encoder=True from _recondition_masklets.
meta-cla
Bot
added
the
CLA Signed
amier2775
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_recondition_masklets encodes detector masks into memory via propagate_in_video_preflight(run_mem_encoder=True), but the subsequent _tracker_update_memories call re-encodes the original tracker masks and overwrites the reconditioned memory for the same frame.
Fix: replace reconditioned objects' masks in tracker_low_res_masks_global before _tracker_update_memories, so a single memory encoding pass uses the correct detector masks. Remove the now-unnecessary run_mem_encoder=True from _recondition_masklets.