Escape social settings inputs with htmlspecialchars (CodeRabbit on #260)#264
Conversation
…tmlHelper::e CodeRabbit flagged the Telegram input for using HtmlHelper::e() in a view, which the project rules forbid — but all six social inputs (facebook/twitter/ instagram/linkedin/bluesky/telegram) had the same pattern. Converted them all to htmlspecialchars(..., ENT_QUOTES, 'UTF-8') for consistency, not just the one CodeRabbit saw.
|
Warning Review limit reached
Next review available in: 17 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
CodeRabbit flagged the Telegram settings input for using
HtmlHelper::e()in a view (against the project's view-escaping rule). All six social inputs (facebook/twitter/instagram/linkedin/bluesky/telegram) shared that pattern, so I converted them all tohtmlspecialchars(..., ENT_QUOTES, 'UTF-8')for consistency — not just the one line CodeRabbit saw.The other two findings on #260 are addressed by reply on the threads: the missing save-time sanitization is by design (the security boundary is output — both the footer render and the Schema.org
sameAsalready run every social throughsanitizePublicHttpUrl(), uniformly for all six), and the re-seed concern is guarded by.installed(the seed only re-runs on a deliberate from-scratch reinstall, not on upgrade/recovery).