v6.4.0#202
Open
fa0311 wants to merge 6 commits into
Open
Conversation
`__lt__`/`__gt__` compared each field with independent `or`, so ordering
was wrong whenever a lower place-value differed in the opposite direction:
Version("v6.0.0") < Version("v5.10.0")
# major 6 < 5 -> False, minor 0 < 10 -> True => returns True (wrong)
Compare the (major, minor, patch) tuples instead, which Python orders
lexicographically — the correct semantic-version behaviour. `__le__`/`__ge__`
delegate to these and are fixed transitively.
ProcessIdManager built its snapshot by calling x.exe() on every process returned by process_iter() — one syscall per process, on a list rebuilt each time new_process() diffs before/after a launch. Switch to process_iter(attrs=["pid", "exe"]), which fetches both fields in one pass and yields None for exe on AccessDenied (same result as the old try/except wrapper), markedly faster on machines with many processes. Also cache get_sid() with lru_cache(maxsize=1): the current user's SID is constant for the process lifetime, so the win32 lookup need not repeat on every scheduled-task operation. No behavioural change.
fix(version): correct semantic version ordering
perf(process_manager): batch process enumeration, cache SID lookup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.