Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 27, 2026
f0rr0
force-pushed
the
f0rr0/patch-correctness-refresh
branch
from
September 29, 2026 18:33
ef4821f to
5b1d7b7
Compare
f0rr0
marked this pull request as ready for review
September 30, 2026 23:14
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
September 29 follow-up: measured fixes
Current head:
8d57e35902367efc8a51b5f16dfd4cc9a55f5a87. This adds one focused commit on top of the September 29 rebase onto main32ce7b29510b74333e799601b69a71fd28122e80.Fixed and verified
is_closed()reflects unusable state, subsequent SQL reports a lifecycle error, and close releases storage for reopen without re-entering the failed guest. Async/TS closed flags retain their settled-shutdown meaning. Interrupted writes still must not be blindly retried.username=appwithsession_user=postgres, andRESET ROLErestores the bootstrap superuser. The PR preservesapp, applies role defaults, denies unauthorized elevation and rejects NOLOGIN. The embedding host still authenticates/selects the caller.Performance: attribution, not a speedup claim
All measurements use retained release executables, balanced serial process runs and validated results on a shared Linux host.
The Rust LLVM/AOT memory-policy percentages do not apply to browser V8. Remaining native PostgreSQL 18.4 INSERT/mixed-workload gaps are not closed. PGlite 0.5.8 remains slower on several tested workloads, but its PG 18.3 and fsync-off policy prevent an engine-only/equivalent-durability comparison.
Local verification of this follow-up
git diff --checkpasses. Local artifacts/manifests are explicitly diagnostic-only, not publishable release evidence. Benchmark machinery and binaries are not staged.Browser fixture caveat: the diagnostic carrier omits the normal cluster seed, so the worker database was initialized through the direct host; this does not qualify fresh seeded worker provisioning. Browser terminal diagnostics still duplicate a bounded historical stderr tail, although the real terminal cause remains present.
Remaining blockers and scope
Keep this PR draft. Windows recovery remains a merge blocker (#208). The PR removes main's incomplete host-exit workaround and exposes the known MSVC Sys exception-recovery failure; it is not claimed to behave identically to main. Upstream's move to V8 requires an actual Windows WASIX/dynamic-linking/cache and SQL-recovery evaluation, not merely a dependency-version bump.
No exact-SHA hosted/release qualification is claimed. Windows/macOS, complete extension lifecycles, fresh concurrent Postmaster qualification, and Node/Bun/Deno N-API end-to-end performance remain outside this local checkpoint. Production stack-exhaustion protection, CPU-bound WASIX cancellation and Postmaster signal semantics remain separate unfinished runtime work.
Keep real ABI and AOT-policy identity checks: changed interfaces must agree, and Wasmer 7.2.1 does not include every codegen flag in its artifact identity. These are publisher/install/open responsibilities, not per-query guards or consumer tuning choices. Matching artifacts does not require rebuilding compatible unchanged outputs.
Earlier rebase, scope and historical evidence
September 29 rebase
Rebased onto remote main
32ce7b29510b74333e799601b69a71fd28122e80. Current head:5b1d7b7b.Preserves main's ABI 12, release versions, bounded streaming queue, streaming archives and COPY callback-abort handling alongside the PR's deadline checks. Both sets of owner tests remain enabled. The standalone queue fixture supplies the new timeout hook and fails if it is unexpectedly invoked. Resource notes were updated for main's queue/archive behavior.
Validation:
moon run liboliphaunt-native:test release-tools:metadatapassed (15 tasks, 10 cached);git diff --checkpassed. Earlier runtime/build evidence below is historical, not qualification of this rebased SHA. Windows recovery blocker remains; this PR stays draft. Pre-rebase headef4821f5remains on the closed #202 branch and local backupf0rr0/backup-pr218-20260929.September 27 scope and evidence (before rebase)
Replacement for #202
Reopened on a new branch against current main so GitHub computes the correct comparison. Exact same head commit
ef4821f50a05db7ecfa2782e2accea5a8c544f5b; no source or scope changes. Historical discussion and evidence remain in #202.Expected diff against main
df2b112e866f8ea76d320d7b3e172cf7be764177: 248 files, +59,360 / -43,720 lines. Most line churn is splitting existing Postmaster patch files, not new engine implementation.Windows clarification: main already has the engine limitation, but its host-exit workaround avoids that path. This change removes that semantically incomplete workaround and exposes the demonstrated Windows crash. It is a compatibility blocker introduced by this recovery transition, not a reproduced identical crash on main. Track the replacement in #208.
September 27 refresh onto current main
The earlier correctness work has been selectively ported onto main
df2b112e866f8ea76d320d7b3e172cf7be764177, preserving its current source/build graph, resources/extensions, seedless browser startup, and extracted Postmaster executor. Existing PR history is preserved; no force push.Not yet merge/release-ready: Windows/MSVC Sys exception recovery remains a blocker for the complete supported matrix. A production early stack guard is not enabled. Fresh Postmaster concurrent runtime and full supported-platform/extension qualification remain outstanding.
Implemented
Fresh local evidence
These are correctness checks, not a comparative performance or release qualification claim. Native fsync-on can cost write latency intentionally.
New dependencies: experiments, not production upgrades
Current implementation, evidence, retained assets and next steps.
Follow-up tracking: #201.