test: replace brittle checks with behavioral coverage - #181
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
f0rr0
force-pushed
the
f0rr0/audit-logic-tests
branch
from
September 29, 2026 12:46
fc0631a to
8cad274
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several tests ran quoted programs in subprocesses, recreated database/framework internals, or only repeated copy and configuration. Replace the useful cases with typed tests of real application functions and route handlers; remove duplicate and superficial checks. The suite is 713 lines smaller, with no application or dependency changes.
Async failures are explicitly awaited, retry times use fixed clocks, and assertions now catch empty chart output and accidental mutation of tracked identities. Keep coverage for privacy/authentication, work ownership and diffs, history boundaries, ingestion retries, metadata decisions and cache warming. No PostgreSQL service is required.
Validation: 284 tests pass normally and in randomized order; typecheck, formatting/lint, both Knip modes and Typst checks pass. Seven temporary mutations covering privacy, cache refreshes, work filtering, snapshot changes, cumulative totals, chart labels and feed regressions were all caught and reverted.