fix(token): throw on reserved token names instead of silently corrupting morgan - #370
Open
Samiullah-2004 wants to merge 1 commit into
Open
fix(token): throw on reserved token names instead of silently corrupting morgan#370Samiullah-2004 wants to merge 1 commit into
Samiullah-2004 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #265
Calling
morgan.token('token', fn)(or 'format'/'compile') silentlyoverwrote morgan's own internal functions, since
token()just doesmorgan[name] = fn. This meant registering a token named "token" woulddestroy
morgan.tokenitself, causing every subsequent.token()callto fail with an unrelated TypeError, with no indication of the real cause.
This PR:
token()that throws a clear TypeError when areserved name (
token,format,compile) is usedmorgan.tokenremains a valid function after a rejected registration (the exact
failure mode from the original bug report)
@dougwilson in the original issue thread
All 91 existing tests still pass.