Conversation
This was referenced Feb 13, 2026
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 107 109 +2
Lines 15713 15944 +231
Branches 860 862 +2
==========================================
+ Hits 15713 15944 +231
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Feb 13, 2026
Merged
wschurman
marked this pull request as ready for review
February 14, 2026 18:53
wschurman
force-pushed
the
wschurman/02-13-fix_refactor_install_method_to_instead_be_free_functions
branch
from
February 16, 2026 00:06
bced9f8 to
429ae05
Compare
wschurman
force-pushed
the
wschurman/02-13-feat_add_postgresentity/readonlypostgresentity_classes_that_expose_knexloader_methods
branch
from
February 16, 2026 00:06
35b6ed0 to
701c768
Compare
ide
approved these changes
Feb 16, 2026
Member
Author
Merge activity
|
wschurman
changed the base branch from
wschurman/02-13-fix_refactor_install_method_to_instead_be_free_functions
to
graphite-base/442
February 16, 2026 21:11
…nexLoader methods
wschurman
force-pushed
the
wschurman/02-13-feat_add_postgresentity/readonlypostgresentity_classes_that_expose_knexloader_methods
branch
from
February 16, 2026 21:15
701c768 to
31ca8c0
Compare
wschurman
deleted the
wschurman/02-13-feat_add_postgresentity/readonlypostgresentity_classes_that_expose_knexloader_methods
branch
February 16, 2026 21:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is part 2 of the refactor described in #441.
It adds subclasses of Entity and ReadonlyEntity that supply the static
knexLoadermethods to keep the ergonomics of the extension but without the monkey-patching.How
Add subclasses, add test.
Test Plan
Run test.