[build-tools] Add ios_signing_backend option to the repack step - #4239
Open
gabrieldonadel wants to merge 2 commits into
Open
[build-tools] Add ios_signing_backend option to the repack step#4239gabrieldonadel wants to merge 2 commits into
gabrieldonadel wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4239 +/- ##
==========================================
+ Coverage 63.73% 63.75% +0.03%
==========================================
Files 1030 1030
Lines 47448 47491 +43
Branches 9977 9991 +14
==========================================
+ Hits 30237 30274 +37
- Misses 17110 17116 +6
Partials 101 101 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We recently added experimental support for running repack for iOS apps on Linux machines starting from the package version 0.9.0. The idea for using Linux machines is that these are cheaper and more available than macOS ones.
This PR exposes that backend as an opt-in input on the
eas/repackstep so we can test it end-to-end on EAS. A follow-up PR in universe adds the matchingios_signing_backendparam to workflow repack jobs.How
ios_signing_backendinput toeas/repack(fastlane|zsign). Default stays fastlane@expo/repack-appdevDependency to~0.9.0for the backend-discriminatedIosSigningOptionsunion. Even though the runtime package is still installed dynamically per job viarepack_version.Test Plan
.p12and profiles to the temp dir, returnsbackend: 'zsign', and never touchesIosCredentialsManager.ios_signing_backend: zsignandruns_on: linux-mediumagainst a real build.Note: v0.9.0 is published as
nexton npm, so jobs opting this require settingrepack_version: nextfor now