Skip to content

[build-tools] Link serve-sim previews to simulator session details - #4237

Draft
szdziedzic wants to merge 1 commit into
mainfrom
szdziedzic-codex/eas-simulator-session-return-link
Draft

[build-tools] Link serve-sim previews to simulator session details#4237
szdziedzic wants to merge 1 commit into
mainfrom
szdziedzic-codex/eas-simulator-session-return-link

Conversation

@szdziedzic

Copy link
Copy Markdown
Contributor

Summary

  • resolve the Expo dashboard URL for an EAS Simulator session
  • pass it to serve-sim through the optional --session-details-url flag
  • keep simulator startup resilient when session metadata cannot be fetched

Companion change

Validation

  • corepack yarn test src/steps/utils/tests/remoteDeviceRunSession.test.ts --runInBand
  • corepack yarn typecheck
  • Oxfmt check on modified files

@github-actions

Copy link
Copy Markdown

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.75%. Comparing base (8439f4f) to head (05a6628).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ld-tools/src/steps/utils/remoteDeviceRunSession.ts 90.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4237      +/-   ##
==========================================
+ Coverage   63.54%   63.75%   +0.22%     
==========================================
  Files        1030     1030              
  Lines       47262    47477     +215     
  Branches     9921     9984      +63     
==========================================
+ Hits        30026    30265     +239     
+ Misses      17135    17111      -24     
  Partials      101      101              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant