[build-tools] Stabilize remote simulator tunnels - #4226
Draft
szdziedzic wants to merge 2 commits into
Draft
Conversation
|
✅ Thank you for adding the changelog entry! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4226 +/- ##
==========================================
+ Coverage 63.54% 63.61% +0.07%
==========================================
Files 1028 1028
Lines 47054 47167 +113
Branches 9891 9914 +23
==========================================
+ Hits 29898 29999 +101
- Misses 17055 17066 +11
- Partials 101 102 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Remote simulator jobs only polled the device-run session status while ngrok forwarding tasks and the agent-device, Argent, and serve-sim processes ran unsupervised. If one of those resources stopped, the already-published URL stayed visible but ngrok returned
ERR_NGROK_3200because its endpoint was offline. The detached-process helper also retained unbounded output.How
Test plan
corepack yarn workspace @expo/build-tools jest-unit --runInBand src/steps/utils/__tests__/remoteDeviceRunSession.test.ts src/steps/functions/__tests__/startArgentRemoteSession-orchestration.test.ts(36 tests passed)corepack yarn workspace @expo/build-tools typecheckcorepack yarn fmt:checkps/pgrepin the sandbox