[build-tools] Use production mode for app config and Expo commands - #4180
Open
ramonclaudio wants to merge 13 commits into
Open
[build-tools] Use production mode for app config and Expo commands#4180ramonclaudio wants to merge 13 commits into
ramonclaudio wants to merge 13 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4180 +/- ##
==========================================
+ Coverage 63.74% 63.86% +0.12%
==========================================
Files 1030 1032 +2
Lines 47477 47511 +34
Branches 9990 9993 +3
==========================================
+ Hits 30260 30338 +78
+ Misses 17116 17072 -44
Partials 101 101 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 12, 2026
ramonclaudio
force-pushed
the
@ramonclaudio/dvt-119-eas-config-mode-handoff
branch
from
August 13, 2026 13:48
0822cb4 to
bdc5d2b
Compare
ramonclaudio
changed the title
3 tasks
ramonclaudio
changed the title
ramonclaudio
changed the title
ramonclaudio
force-pushed
the
@ramonclaudio/dvt-119-eas-config-mode-handoff
branch
from
August 16, 2026 14:13
ad8a21c to
0822cb4
Compare
ramonclaudio
added a commit
to expo/expo
that referenced
this pull request
Aug 17, 2026
# Why The EAS changes in [#4180](expo/eas-cli#4180) tell Expo to use development or production mode when loading app config, so we needed a temporary internal environment variable that Expo reads and removes before app config loads. # How I added `__EXPO_CONFIG_MODE` as an internal handoff that `@expo/env` reads and removes before Expo loads the dotenv files and app config. I blocked `.env` files from setting the handoff and updated `getOriginalEnv()` and `getOriginalEnvValue()` to exclude dotenv values inherited from a parent process. We still use `EAS_BUILD` as the production fallback for older EAS versions. # Test Plan Tests and package checks pass. # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
ramonclaudio
force-pushed
the
@ramonclaudio/dvt-119-eas-config-mode-handoff
branch
from
August 18, 2026 22:23
0822cb4 to
e3e4ea2
Compare
ramonclaudio
restored the
@ramonclaudio/dvt-119-eas-config-mode-handoff
branch
August 18, 2026 22:54
ramonclaudio
force-pushed
the
@ramonclaudio/dvt-119-eas-config-mode-handoff
branch
from
August 19, 2026 14:30
a028130 to
f045885
Compare
ramonclaudio
force-pushed
the
@ramonclaudio/dvt-119-eas-config-mode-handoff
branch
from
August 19, 2026 18:51
f045885 to
2ce2235
Compare
ramonclaudio
changed the title
ramonclaudio
marked this pull request as ready for review
August 19, 2026 19:23
ramonclaudio
marked this pull request as draft
August 19, 2026 21:34
ramonclaudio
force-pushed
the
@ramonclaudio/dvt-119-eas-config-mode-handoff
branch
from
August 21, 2026 14:08
2ce2235 to
df98b5f
Compare
|
✅ Thank you for adding the changelog entry! |
Member
Author
|
/review |
🤖 AI code reviewDecision: Ready for human review Overall PR risk: High. The change modifies existing behavior. It forces No findings. This review is advisory — it never blocks a merge and never auto-approves. |
Member
Author
|
/verify |
ramonclaudio
marked this pull request as ready for review
August 21, 2026 17:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
EAS Build can use an existing
NODE_ENVwhen it loads app config or runs Expo commands, which can make it load different env files for the same build.How
I updated EAS Build to use
productionmode for app config, prebuild, Expo Doctor, and runtime version resolution, and kept the original build env for dep installs.Test Plan
Tests and CI checks pass.