Revamp spec parsing to handle duplicate test names in different sections - #23
Merged
Merged
Conversation
IsaacG
approved these changes
Jun 7, 2026
Contributor
Author
|
The test runner can now differentiate the test with their "fully qualified" names: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This popped up while I was doing list-ops in the web editor. That exercise has lots of duplicated test names in different
describesections. The previous behaviour would be to only remember the last test of its name.This iteration stores the "fully qualified" test name:
list-ops: append entries to a list and return the new list: empty listslist-ops: concatenate a list of lists: empty listslist-ops: filter list returning only values that satisfy the filter function: empty lists