Keep blank REPL lines when the prompt has no trailing space - #226
Open
BetterAndBetterII wants to merge 1 commit into
Open
BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
formatCopyText only matched prompts like ">>> " (trailing space), so a bare ">>>" blank line was dropped when onlyCopyPromptLines is set. Retry the prompt against line+" " and keep the line if the remainder is empty, which does not treat "$PATH" as a "$ " prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
formatCopyTextonly matched a prompt with its trailing space (>>>). A blank REPL line is often just>>>, which is not empty after trim, soonlyCopyPromptLinesdropped it. Copying the last docs example therefore lost the empty line between statements.If a line does not match, retry against
line + ' 'and accept that match only when the remainder is empty. That keeps the blank line and does not treat$PATHas a$prompt.Fixes #197