Fix website build Deno compatibility - #2599
Merged
Merged
Conversation
|
ejsmith
marked this pull request as ready for review
September 29, 2026 14:59
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v8.10.0 website build fails because Deno 2.5.7 does not export
node:module.registerHooks, which the existing Lume 3.3.1 dependency imports. Pin the website workflow to Deno 2.9.7 so the existing site builds successfully.Validation: reproduced the failure locally with Deno 2.5.7, then passed
deno task check,deno task verify(including four tests, telemetry verification, and local link/asset checks), and the unused-asset check with 2.9.7 using a dummy telemetry key and localhost collector. The existing unused-asset report remains non-failing. No dependency or lockfile changes, public API changes, or release-tag changes.Reviewed the Deno 2.9.7 release notes, loader-hook documentation, and published security advisories. This only changes the website build runtime; application runtimes are unaffected.
Failure: v8.10.0 website workflow.