fix: use Display formatting for tracing fields instead of Debug formatting#255
Conversation
Switch tracing fields from Debug (?) to Display (%) for Address, B256, and error types so trace output is consumer-friendly (0x-prefixed hex, human-readable error messages) rather than Rust-specific (raw bytes, enum variants). Unwrap Option<u64> gas_limit to emit a plain number instead of Some(...). Remove full struct Debug dump of config.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughStandardizes tracing field formatting by replacing debug-style ( ChangesTracing Field Formatting Standardization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
GasOutput is a struct without Display/Value impls, so it must stay as Debug. Use shorthand %caller/%addr syntax in mint precompile instead of redundant caller = %caller.
Description
Type of Change
Some telemetry outputs were using Debug formatting, so were repesented as
Some(1000)rather than"1000". This PR updates the outputs to be non-rust specific for easier parsing.Related Issues
Fixes #(issue)
Checklist
Testing
Additional Notes
Summary by CodeRabbit