You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR splits the two-way-network-split.yaml playbook into two distinct tests: two-way-network-split-non-finality.yaml (epoch-based, asserts finality stops) and two-way-network-split-reorg-trigger.yaml (slot-based, focuses on reorg triggers). Both get registered in _index.yaml. The changes are generally coherent; the substantive fix for minUnfinalizedEpochs with values < 2 is sound. One minor concern remains.
Issues
🟡playbooks/_index.yaml:2,4 — The generated timestamp comment and YAML frontmatter both changed (2026-05-19T21:36:30Z → 2026-05-21T07:03:46Z). These are auto-generated by scripts/generate-playbook-index.sh and will produce spurious diffs every time the index is regenerated. Consider either using a stable/constant value (e.g. generated: stable) or instructing the generator to skip writing this line if its only purpose is documentation.
🟡playbooks/dev/two-way-network-split-reorg-trigger.yaml — Extraction of get_consensus_specs removes SLOTS_PER_EPOCH as a dependency, which is correct for a slot-duration-based playbook. However, if this playbook is ever repurposed to use epoch-based duration in the future (e.g., by adding a splitDurationEpochs configVar), the get_consensus_specs task won't still be there and the jq expression will silently produce no result. This is an internal consistency trap worth documenting in the config section comment.
Suggestions
playbooks/_index.yaml:266 — The renamed playbook entry (id: two-way-network-split-reorg-trigger) is adjacent in the diff to the new non-finality entry, but in the actual YAML file they remain ordered non-finality then reorg-trigger. Confirm this ordering is intentional; if alphabetical by tag group is preferred, verify the _index ordering aligns with the playbook file ordering.
Reviewed @ b8ef5961 "If you can't measure it, you can't improve it." — Peter Drucker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
two-way-network-split-reorg-triggertwo-way-network-split-non-finalityplaybook that preserves the unfinalized-epoch assertion with a 2-epoch floorValidation
make generate-playbook-indexgo test ./...Notes
splitDurationSlotsand only requires fresh finality after healing.splitDurationEpochsand enforces non-finality before healing.