refactor(tests): enhance EIP-8037 test coverage part 4 - #3511
refactor(tests): enhance EIP-8037 test coverage part 4#3511LouisTsai-Csie wants to merge 1 commit into
Conversation
14d587c to
dcc46aa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3511 +/- ##
===================================================
+ Coverage 93.90% 94.01% +0.10%
===================================================
Files 624 624
Lines 36905 36905
Branches 3326 3326
===================================================
+ Hits 34655 34695 +40
+ Misses 1569 1533 -36
+ Partials 681 677 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dcc46aa to
a651f5b
Compare
spencer-tb
left a comment
There was a problem hiding this comment.
Amazing addition coverage @LouisTsai-Csie! Thanks so much, a couple of comments ;)
| ) | ||
|
|
||
| sender = pre.fund_eoa() | ||
| created = compute_create_address(address=sender, nonce=0) |
There was a problem hiding this comment.
compute_create_address is undefined here. Please add it to the execution_testing imports. This currently causes all 30 fixture-generation variants of this test to fail with NameError :)
| dominant_dimension: str, | ||
| ) -> None: | ||
| """ | ||
| Assert the miner is paid on `max(execution, state)`, whichever leads. |
There was a problem hiding this comment.
This should say the miner is paid on execution + state, matching expected_coinbase below. max(execution, state) applies to block-header/base-fee accounting, not the transaction charge. Could we also rename the test to reflect that it includes both dimensions?
Description
Enhancing EIP-8037 testing coverage:
For each test file: (1) define suite scope, (2) analyze existing cases, (3) identify gaps, (4) filter impossible scenarios, (5) add missing tests, in order to expand EIP-8037 test coverage for state-gas pricing, reservoir accounting, refund behavior, transaction validity, and two-dimensional block gas accounting.
Changes
The changes primarily extend existing test matrices and parameterize related execution paths so that shared setup is reused and equivalent scenarios are not duplicated.
Expected values verify:
gas_usedusesmax(block_execution, block_state);Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture