chore(test-specs): avoid silent mistakes when writing tests - #3510
Merged
fselmo merged 11 commits intoSep 2, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3510 +/- ##
================================================
Coverage 94.01% 94.01%
================================================
Files 624 624
Lines 36905 36905
Branches 3326 3326
================================================
Hits 34695 34695
Misses 1533 1533
Partials 677 677
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
marioevz
approved these changes
Sep 2, 2026
marioevz
left a comment
Member
There was a problem hiding this comment.
Awesome fixes! Just had one request. Approving for now so we can merge once implemented.
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On a review of #3486, I asked one of the Claude agents to sweep the related framework for gotchas that could lead to silent
fillfor the wrong reasons. It came back with some hits but fell our of scope for that PR, so I'm adding these here with unit tests. This is also important for DevEx but it's mostly important as a security so we don't end up with footguns that canfilltests but end up with unintended JSON fixtures because of silent overrides of certain things the test itself didn't mean to create.This shouldn't change anything related to the current state of the tests but I did run
hasher compareon a fill of eip7928 module at the currentforks/amsterdamand on this branch, just as a sanity check, and it's exact.Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture