fix(test-cli): ignore tests/json_loader and tests/spec_tools during collection - #3461
Merged
danceratopz merged 1 commit intoAug 28, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3461 +/- ##
================================================
Coverage 93.77% 93.77%
================================================
Files 624 624
Lines 36905 36905
Branches 3326 3326
================================================
Hits 34606 34606
Misses 1597 1597
Partials 702 702
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
check_eip_versionscollectstests/json_loaderandtests/spec_tools, whose items carry aforkparameter but no spec type format, and then crashes during collection. It is the same failure #3450 fixed forfillandexecute:pytest-fill.ini,pytest-execute.iniandpytest-execute-hive.iniall ignore both directories.pytest-check-eip-versions.inihas never carried an--ignoreline and also setstestpaths = tests/, so it is the one config that still reaches them.Toggling each ignore and reading the collected count puts 938 items in scope, 630 under
tests/json_loaderand 308 undertests/spec_tools. Nothing is lost by skipping them:is_test_for_an_eipmatcheseip\d{1,4}against the module path, so neither directory can produce anEIPSpecTestItem. With the two ignores,check_eip_versions --collect-onlygoes from an abort to44384/189010 tests collected.On master the same run then dies a second time in the
tests/json_loaderteardown with aKeyError, which #3460 guards. The two are independent; this one fixes the command on its own.Related Issues or PRs
Follows #3450, which made the same fix for the other three configs.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture