chore(tests): Remove hard-coded gas limits from system contract tests - #3457
Open
zexoverz wants to merge 2 commits into
Open
chore(tests): Remove hard-coded gas limits from system contract tests#3457zexoverz wants to merge 2 commits into
zexoverz wants to merge 2 commits into
Conversation
Backport the runtime gas measurement from the EIP-8282 out-of-gas tests to the EIP-7002 and EIP-7251 ones, so the boundary no longer depends on values read off a trace. Claude-Session: https://claude.ai/code/session_01CWCwisL95EQwmp51L72uQ7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of the runtime gas measurement @marioevz described in the issue: the relay contract warms the predeploy, measures a call with
GASon both sides, subtracts a zero-gas probe of the same call, and forwards that minus one to the request it wants starved.SystemContractInteractionMeasuredOutOfGasContractalready exists from EIP-8282, so this is only a rewrite of the parametrization.The two EOA-transaction cases are the ones that carried the trace values, and there is no way to measure a transaction-level gas limit at runtime, so they become a single relay-contract case per file. First-position and last-position starvation are still covered by the existing coarse cases below them. Fixture drift for the untouched cases is limited to the
_infodocstring and line anchor.Related Issues or PRs
Fixes #3071.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture