feat: add auto-RTL for mixed-script content in auto mode - #96
Open
alinadaf wants to merge 1 commit into
Open
Conversation
When auto mode is active and the setting is enabled, lines containing RTL scripts (Arabic, Hebrew, Persian, etc.) are treated as RTL regardless of their first directional character. Works in both editor (CodeMirror line decorations) and reading view (MarkdownPostProcessor). Includes a toggle in settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new setting Auto-RTL for mixed LTR/RTL content (disabled by default) that, when enabled in auto mode, overrides the browser's first-strong-character heuristics for lines containing RTL scripts.
Details
Problem
When a line starts with English text but contains Arabic, Hebrew, or Persian later (e.g.
Hello سلام), the browser'sdir="auto"sees the first strong character (Latin) and renders the line LTR — which is incorrect.Solution
buildDecorations()to check each line for RTL characters when auto mode + setting enabled, applyingdir="rtl"when found.applyMixedContentRTL()that appliesdir="rtl"to block elements (p, li, h1-h6, td, th, blockquote) containing RTL scripts in reading view.RTL_CHAR_REGEXandhasRtlChar()utility.autoRTLForMixedContentwith UI toggle.Testing
Set default direction to Auto, enable the new setting, and type mixed LTR/RTL content in a note.