Remove inert skills/ copy of query-plan-analysis#386
Merged
Conversation
Claude Code never discovered this directory. Skills are only loaded from ~/.claude/skills/, .claude/skills/, or a plugin bundle -- a bare skills/ path at a repo root does nothing. The copy added in #385 was therefore nine files of documentation that no agent could load, and it had already drifted: its SKILL.md still resolves scripts/extract.py against a repo path, which is wrong once the skill is installed as a plugin and its directory is unguessable. The skill now ships from erikdarlingdata/claude-plugins as a Claude Code plugin: /plugin marketplace add erikdarlingdata/claude-plugins /plugin install query-plan-analysis@erikdarling It was moved out rather than promoted here because reaching this repo's default branch requires a dev -> main PR, which auto-fires release.yml and demands a version bump -- shipping a Velopack auto-update to every user for a change containing no application code. One coupling to keep in mind: the skill's references/timing.md is transcribed from src/PlanViewer.Core/Services/PlanAnalyzer.Timing.cs and NodeTimeAttribution.cs (row-mode cumulative vs batch-mode standalone times, exchange operators accumulating downstream waits, per-thread rather than cross-thread subtraction). If those semantics change, update the skill repo; nothing will catch the drift. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the file addition from #385. The skill itself is not going away — it moved somewhere it actually works.
Why this directory did nothing
Claude Code discovers skills from exactly three places:
~/.claude/skills/,.claude/skills/, and plugin bundles. A bareskills/directory at a repo root is not one of them. Soskills/query-plan-analysis/was nine files of documentation that no agent could load. Merging it looked like shipping a skill; it shipped a folder.It had also already drifted. Its
SKILL.mdtells the agent to resolvescripts/extract.pyagainst a repo path — which is wrong the moment the skill is installed as a plugin, because the install location is unguessable.Where it went
erikdarlingdata/claude-plugins, as a proper Claude Code plugin in a marketplace repo:Verified end to end against the real remote, not a local directory: marketplace added, plugin installed and enabled, extractor runs from the installed cache.
Why not just promote it to main here
/plugin marketplace add owner/repofetches the repo's default branch. Reachingmainin this repo means adev -> mainPR, and:check-version-bump.ymlrequires a version bump on any such PRrelease.ymlfires on that PR closing, building installers and Velopack packagesSo hosting the marketplace here would have forced a v1.15.1 release and pushed an auto-update to every 1.15.0 user for a change containing zero application code.
skills/is referenced by no.csproj, no installer, and no workflow.No coupling left behind
The commit message on this branch claims the skill's
references/timing.mdis coupled toPlanAnalyzer.Timing.csand will silently drift. That overstates it, and the claim is withdrawn.timing.mdwas checked against that file while being written, but it does not depend on it. Both independently encode SQL Server showplan semantics — row-mode operator times cumulative, batch-mode standalone, exchange operators accumulating downstream wait time, thread 0 as coordinator, the cardinality estimator's fixed guess selectivities. Those are properties of SQL Server, not of this codebase, and they have been stable for the better part of two decades. Nothing here needs to track anything there.Test plan
grepforskills/query-plan-analysisacross the repo: the only match was inside the deleted directory itself..csproj,.props, installer, or workflow referencesskills/.build-and-test,check-branches).🤖 Generated with Claude Code