Skip to content

Potential mismatch with latex code structure #48

Description

@erickschulz

In the process of refactoring compilation and testing, changes were made to the code that might now differ from the latex.

  • Some anonymous functions in .cc files needed to be declared in a .h
  • Some functions fully implemented in .h files were implemented now in .cc
  • Source .cc are not not included directly in tests
  • and related changes that enforced good practice and allowed for single compilation

On the tests and actual implementation side, some number of iterations were modified to reduce run time on the pipeline. They could be increased later when everything is fixed.

I do not have a list of those at the moment, because to generate a proper diff i would need to run a clang-format on everything again with the right version (and even then it was inconsistently applied on the whole gitlab repo that I moved back here on github). I have since then removed the clang-format from the pipeline checks.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions