Simplify handling of --bigint in finalize_wasm. NFC - #27570
Merged
Conversation
Collaborator
Author
|
As a followup I plan to remove this redundant flag from binaryen WebAssembly/binaryen#9016 |
In `wasm-emscripten-finalize`, both `--bigint` and `--no-legalize-javascript-ffi` have the exact same effect: they prevent running the `legalize-js-interface` pass (`if (!bigInt && legalizeJavaScriptFFI)`). Previously, when `WASM_BIGINT` was enabled, Emscripten was passing both `--bigint` and `--no-legalize-javascript-ffi`. In addition, when `AUTODEBUG` was enabled, `--bigint` was appended a second time. Consolidate the check so `--bigint` is passed once when either `WASM_BIGINT` or `AUTODEBUG` is enabled, and remove the redundant `--no-legalize-javascript-ffi` flag. Split out from emscripten-core#27558.
sbc100
force-pushed
the
simplify_finalize_bigint
branch
from
August 19, 2026 20:11
1c99066 to
12b2a02
Compare
sbc100
enabled auto-merge (squash)
August 19, 2026 20:55
dschuff
approved these changes
Aug 19, 2026
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Aug 19, 2026
This flag was redundant given that we have `--bigint`. See emscripten-core/emscripten#27570 for where we stop using it in emscripten.
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Aug 20, 2026
…9016) This flag was redundant given that we have `--bigint`. See emscripten-core/emscripten#27570 for where we stop using it in emscripten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
wasm-emscripten-finalize, both--bigintand--no-legalize-javascript-ffihave the exact same effect: they prevent running thelegalize-js-interfacepass (if (!bigInt && legalizeJavaScriptFFI)).Previously, when
WASM_BIGINTwas enabled, Emscripten was passing both--bigintand--no-legalize-javascript-ffi. In addition, whenAUTODEBUGwas enabled,--bigintwas appended a second time.Consolidate the check so
--bigintis passed once when eitherWASM_BIGINTorAUTODEBUGis enabled, and remove the redundant--no-legalize-javascript-ffiflag.Split out from #27558.