Move LEGALIZE_JS_FFI to legacy settings list - #27568
Merged
Merged
Conversation
sbc100
changed the title
sbc100
changed the title
LEGALIZE_JS_FFI to legacy settings list
kripken
approved these changes
Aug 19, 2026
Collaborator
Author
|
I'm gonna land #27569 first which makes this change even smaller. |
sbc100
force-pushed
the
deprecate_legalize_js_ffi
branch
from
August 19, 2026 19:37
2fc5d96 to
9e2405c
Compare
Move `LEGALIZE_JS_FFI` to `LEGACY_SETTINGS` (accepting only `0` for backwards compatibility). JS FFI legalization is no longer needed under the default `WASM_BIGINT` configuration and is now conditioned directly on `WASM_BIGINT=0`. Split out from emscripten-core#27558.
sbc100
force-pushed
the
deprecate_legalize_js_ffi
branch
from
August 19, 2026 19:40
9e2405c to
5d9c9da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
LEGALIZE_JS_FFItoLEGACY_SETTINGS(accepting only0for backwards compatibility). JS FFI legalization is no longer needed under the defaultWASM_BIGINTconfiguration and is now conditioned directly onWASM_BIGINT=0.Split out from #27558.