styles/exported: use CSS vars - #1005
Merged
Merged
Conversation
wpkelso
reviewed
Sep 4, 2026
wpkelso
left a comment
wpkelso
left a comment
Member
There was a problem hiding this comment.
Looks overall good, just a couple of small questions I still have. I think overall we should be shifting away from the gtk css color extensions toward native css functions, but I don't know if you consider that in-scope for this PR or not.
Member
Author
|
@wpkelso I agree and I think it makes sense to switch the ones that we're touching at least. Good call |
Member
Author
|
@wpkelso okay this now uses color-mix for all changed lines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doens't fix all the variable usage yet, but it does fix exported variables