Skip to content

[CONVOY-1877] fix(structprop): improve parser error messages and fix token formatting - #22

Merged
ngonhu159 merged 2 commits into
masterfrom
fix/structprop-parser-error-messages
Jul 27, 2026
Merged

[CONVOY-1877] fix(structprop): improve parser error messages and fix token formatting#22
ngonhu159 merged 2 commits into
masterfrom
fix/structprop-parser-error-messages

Conversation

@ngonhu159

@ngonhu159 ngonhu159 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor
  • Fix format_error_token() to use token objects as mapping keys (previously showed raw tuple repr like ('OPEN',) in errors)
  • Clarify all ParserError messages with better context
  • Show source line in parse errors only when available
  • ci: update GitHub Actions to use Python 3.9 and modern actions

Activities: CONVOY-1877

@ngonhu159
ngonhu159 requested a review from a team July 24, 2026 03:47
@ngonhu159
ngonhu159 force-pushed the fix/structprop-parser-error-messages branch from ce26a99 to 4a16a63 Compare July 24, 2026 04:21
Nhu Ngo added 2 commits July 24, 2026 11:25
- Fix format_error_token() to use token objects as mapping keys
  (previously showed raw tuple repr like ('OPEN',) in errors)
- Clarify all ParserError messages with better context
- Show source line in parse errors only when available

Activitíe: CONVOY-1877
- Replace actions/checkout@v2 with actions/checkout@v4
- Replace actions/setup-python@v2 with actions/setup-python@v5
- Remove Python 2.7 and 3.6 (no longer available on GitHub Actions runners)
- Use Python 3.9 as the only test target

Activities: CONVOY-1877
@ngonhu159
ngonhu159 force-pushed the fix/structprop-parser-error-messages branch from 4a16a63 to 08219e7 Compare July 24, 2026 04:25

@nghiachitran nghiachitran left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngonhu159
ngonhu159 merged commit 57503de into master Jul 27, 2026
3 checks passed
@ngonhu159
ngonhu159 deleted the fix/structprop-parser-error-messages branch July 27, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants