feat(spire): Add stuff we need to the upstream SPIRE k8s registrar - #1
Merged
Merged
Conversation
bleggett
force-pushed
the
bleggett/set-pod-fields-first
branch
from
September 23, 2026 22:00
0f792cf to
73a93ea
Compare
Signed-off-by: Benjamin Leggett <benjamin@edera.io>
bleggett
force-pushed
the
bleggett/set-pod-fields-first
branch
from
September 23, 2026 22:02
73a93ea to
657ce5b
Compare
Signed-off-by: Benjamin Leggett <benjamin@edera.io>
bleggett
force-pushed
the
bleggett/set-pod-fields-first
branch
from
September 23, 2026 22:05
657ce5b to
08a05f2
Compare
Signed-off-by: Benjamin Leggett <benjamin@edera.io>
bleggett
force-pushed
the
bleggett/set-pod-fields-first
branch
from
September 23, 2026 22:20
08a05f2 to
afee36f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of these are pretty minor and I plan to upstream, however the
support additive ClusterSPIFFEIDschange in this fork intentionally avoids mutating the CRDs, so we can use stock upstream CRDs as-is. Upstream will probably want to do this differently.