Skip to content

MeteoSwiss language additions - #306

Open
sibcse wants to merge 6 commits into
ecmwf:developfrom
sibcse:mch_language_additions
Open

sibcse wants to merge 6 commits into
ecmwf:developfrom
sibcse:mch_language_additions

Conversation

@sibcse

@sibcse sibcse commented Oct 9, 2026

Copy link
Copy Markdown

Description

This covers all additions in language.yaml to support MeteoSwiss models/datasets.

  • add models: icon-ch1-eps, icon-ch2-eps, icon-rea-l-ch1
  • add reanl stream
  • add new levtypes:
    • hmsl, we use it for
      'hmsl' = {typeOfFirstFixedSurface=102; typeOfSecondFixedSurface=102;}
      'hmsl' = {typeOfFirstFixedSurface=102; typeOfSecondFixedSurface=255;}
      
    • rfl: We use it for 'rfl' = {typeOfFirstFixedSurface=25; typeOfSecondFixedSurface=255;}; the levels describe reflectivities in dBz (echotop)

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@sibcse

sibcse commented Oct 9, 2026

Copy link
Copy Markdown
Author

FYI @cosunae
Happy to discuss @danovaro !

@danovaro danovaro added the approved-for-ci Approved to run CI on ECMWF machines label Oct 12, 2026
@danovaro
danovaro force-pushed the mch_language_additions branch from dc51df2 to 30be339 Compare October 12, 2026 15:49
@github-actions github-actions Bot removed the approved-for-ci Approved to run CI on ECMWF machines label Oct 12, 2026
@danovaro danovaro added the approved-for-ci Approved to run CI on ECMWF machines label Oct 12, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.57%. Comparing base (958c29b) to head (30be339).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #306   +/-   ##
========================================
  Coverage    50.57%   50.57%           
========================================
  Files          484      484           
  Lines        23204    23204           
  Branches      1634     1634           
========================================
  Hits         11735    11735           
  Misses       11469    11469           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot removed the approved-for-ci Approved to run CI on ECMWF machines label Oct 14, 2026
@danovaro
danovaro force-pushed the mch_language_additions branch from 917314f to d1be4af Compare October 15, 2026 11:02
@danovaro danovaro added the approved-for-ci Approved to run CI on ECMWF machines label Oct 15, 2026
@sebvi

sebvi commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

where is the ADR for this? Do we have a meeting booked to discuss this?

@danovaro
danovaro force-pushed the mch_language_additions branch from d1be4af to e0e88a4 Compare October 17, 2026 13:33
@github-actions github-actions Bot removed the approved-for-ci Approved to run CI on ECMWF machines label Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants