Repository navigation
improved config parsing (RemoteFieldLocation) - #362
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new scalar parsing and error behavior lacks focused automated tests.
1 open finding
What changed in this PR
Improves remote configuration parsing and diagnostics.
Changes:
- Accepts scalar
RemoteFieldLocationvalues. - Replaces assertions with descriptive exceptions for invalid scalar values.
- Applies namespace formatting cleanup.
| File | Description |
|---|---|
src/fdb5/remote/RemoteConfiguration.cc |
Updates remote protocol configuration parsing. |
src/fdb5/tools/fdb-fam.cc |
Normalizes namespace formatting. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| } | ||
| else { | ||
| if (rfl.isNumber()) { |
danovaro
force-pushed
the
fix/remote-config-parsing
branch
from
October 12, 2026 13:23
70967eb to
5f43aa8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #362 +/- ##
===========================================
- Coverage 77.53% 77.50% -0.03%
===========================================
Files 414 414
Lines 27755 27765 +10
Branches 2742 2747 +5
===========================================
Hits 21519 21519
- Misses 6236 6246 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
danovaro
force-pushed
the
fix/remote-config-parsing
branch
from
October 13, 2026 13:10
5f43aa8 to
d6ab01f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
improved config parsing (accepts single value for RemoteFieldLocation) & improved error reporting (instead of ASSERT)
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/fdb/pull-requests/PR-362