Skip to content

[2113] Handle control node graphical nodes on AFV diagram background#2282

Draft
jerome-obeo wants to merge 1 commit into
eclipse-syson:mainfrom
jerome-obeo:jgo/enh/handle_control_actions_on_action_flow_view_diagram
Draft

[2113] Handle control node graphical nodes on AFV diagram background#2282
jerome-obeo wants to merge 1 commit into
eclipse-syson:mainfrom
jerome-obeo:jgo/enh/handle_control_actions_on_action_flow_view_diagram

Conversation

@jerome-obeo

Copy link
Copy Markdown
Contributor

Bug:#2113

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

Bug:eclipse-syson#2113
Signed-off-by: Jerome Gout <jerome.gout@obeosoft.com>
@jerome-obeo jerome-obeo force-pushed the jgo/enh/handle_control_actions_on_action_flow_view_diagram branch from 842e700 to de69c16 Compare June 17, 2026 15:19
@AxelRICHARD AxelRICHARD added this to the 2026.7.0 milestone Jun 17, 2026
}

protected void addReusableCustomNodes(IViewDiagramElementFinder cache, List<NodeDescription> childrenNodes) {
cache.getNodeDescription(this.descriptionNameGenerator.getNodeName(DecisionActionNodeDescriptionProvider.DECISION_ACTION_NAME))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to change that?
Is there a problem with adding them as children of the FakeNodeDescription?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no reusedChildren api on DiagramDescription, I don't see other option than moving all node descriptions as children of diagram description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle start/end/merge/decision... graphical nodes on Action Flow View diagram background

2 participants