Skip to content

Remove using namespace from headers - #446

Open
arkybruh7 wants to merge 6 commits into
eclipse-score:mainfrom
arkybruh7:removing-using-namespace
Open

Remove using namespace from headers#446
arkybruh7 wants to merge 6 commits into
eclipse-score:mainfrom
arkybruh7:removing-using-namespace

Conversation

@arkybruh7

Copy link
Copy Markdown

Description

Removed all using namespace declarations from header files and qualified the affected symbols explicitly.

Related ticket

closes #411 (improvement ticket)

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 9b71a480-c980-4b8c-85ad-45c5b68d5b27
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (33 packages loaded, 10 targets configured)

Analyzing: target //:license-check (88 packages loaded, 10 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (144 packages loaded, 2483 targets configured)

Analyzing: target //:license-check (158 packages loaded, 5891 targets configured)

Analyzing: target //:license-check (160 packages loaded, 9340 targets configured)

Analyzing: target //:license-check (170 packages loaded, 9395 targets configured)

Analyzing: target //:license-check (170 packages loaded, 9397 targets configured)

INFO: Analyzed target //:license-check (175 packages loaded, 11535 targets configured).
[8 / 16] Creating source manifest for @@score_tooling+//dash/tool/formatters:dash_format_converter [for tool]; 0s local
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 29.051s, Critical Path: 2.58s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@danth danth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. In order to proceed, you need to be covered by the necessary legal agreements.

This means having an Eclipse account linked to your GitHub account: https://eclipse-score.github.io/score/main/contribute/general/contribution_attribution.html

Then, sign the Eclipse Contributor Agreement within your Eclipse account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

Remove all using namespace from headers

2 participants