Skip to content

Faster pre-commit - #445

Merged
MaciejKaszynski merged 2 commits into
eclipse-score:mainfrom
etas-contrib:faster-pre-commit
Aug 11, 2026
Merged

Faster pre-commit#445
MaciejKaszynski merged 2 commits into
eclipse-score:mainfrom
etas-contrib:faster-pre-commit

Conversation

@danth

@danth danth commented Aug 10, 2026

Copy link
Copy Markdown
Member
  • Avoid running Bazel once per file when those files had already been formatted by the previous hook
  • Use a faster implementation of the copyright fixer

Should be merged after #447

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 12868203-c0e0-4840-be32-fd7e6297f7c5
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (35 packages loaded, 10 targets configured)

Analyzing: target //:license-check (89 packages loaded, 10 targets configured)

Analyzing: target //:license-check (141 packages loaded, 1037 targets configured)

Analyzing: target //:license-check (157 packages loaded, 6228 targets configured)

Analyzing: target //:license-check (162 packages loaded, 6249 targets configured)

Analyzing: target //:license-check (167 packages loaded, 6298 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

INFO: Analyzed target //:license-check (175 packages loaded, 11535 targets configured).
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 25.723s, Critical Path: 2.42s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@danth
danth force-pushed the faster-pre-commit branch from abd58ac to c2c7b94 Compare August 10, 2026 15:49
@danth
danth requested a deployment to workflow-approval August 10, 2026 15:49 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval August 10, 2026 15:49 — with GitHub Actions Waiting
@danth
danth force-pushed the faster-pre-commit branch from c2c7b94 to dfd14c7 Compare August 11, 2026 08:20
@danth
danth requested a deployment to workflow-approval August 11, 2026 08:20 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval August 11, 2026 08:20 — with GitHub Actions Waiting
@danth
danth force-pushed the faster-pre-commit branch from dfd14c7 to daf5058 Compare August 11, 2026 08:22
@danth
danth requested a deployment to workflow-approval August 11, 2026 08:22 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval August 11, 2026 08:22 — with GitHub Actions Waiting
@danth
danth force-pushed the faster-pre-commit branch from daf5058 to 087cc59 Compare August 11, 2026 10:29
@danth
danth requested a deployment to workflow-approval August 11, 2026 10:29 — with GitHub Actions Abandoned
@danth
danth requested a deployment to workflow-approval August 11, 2026 10:29 — with GitHub Actions Waiting
Comment thread .pre-commit-config.yaml Outdated
danth added 2 commits August 11, 2026 11:50
C++ files are already formatted by the general `//:format.fix`,
if we just enable it for them.

This means we only start up Bazel once, rather than per file,
which makes it faster.
@danth
danth force-pushed the faster-pre-commit branch from 087cc59 to fb22ad3 Compare August 11, 2026 10:51
@danth
danth requested a deployment to workflow-approval August 11, 2026 10:51 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval August 11, 2026 10:51 — with GitHub Actions Waiting
@danth
danth requested a review from MaciejKaszynski August 11, 2026 10:51
@MaciejKaszynski
MaciejKaszynski merged commit 8b9a840 into eclipse-score:main Aug 11, 2026
16 of 18 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants