Skip to content

Add unit tests for watchdog in ProcessGroupManager - #444

Merged
MaciejKaszynski merged 7 commits into
eclipse-score:mainfrom
etas-contrib:feature/add-watchdog-tests-for-process-group-manager
Aug 11, 2026
Merged

Add unit tests for watchdog in ProcessGroupManager#444
MaciejKaszynski merged 7 commits into
eclipse-score:mainfrom
etas-contrib:feature/add-watchdog-tests-for-process-group-manager

Conversation

@cameron-craig-etas

@cameron-craig-etas cameron-craig-etas commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

#439

This PR adds unit tests for the watchdog functionality in ProcessGroupManager. Mocks have been added where needed.

The tests are following the unit test guidelines here: https://eclipse-score.github.io/process_description//main/process_areas/verification/guidance/verification_specification.html

@github-actions

github-actions Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 56cbe7b5-bc21-49c3-b3f4-085785bcf054
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (33 packages loaded, 10 targets configured)

Analyzing: target //:license-check (88 packages loaded, 10 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (93 packages loaded, 20 targets configured)

Analyzing: target //:license-check (150 packages loaded, 3061 targets configured)

Analyzing: target //:license-check (159 packages loaded, 6833 targets configured)

Analyzing: target //:license-check (163 packages loaded, 9345 targets configured)

Analyzing: target //:license-check (163 packages loaded, 9345 targets configured)

Analyzing: target //:license-check (171 packages loaded, 9521 targets configured)

INFO: Analyzed target //:license-check (175 packages loaded, 11535 targets configured).
[12 / 16] [Prepa] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 27.966s, Critical Path: 2.48s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@cameron-craig-etas cameron-craig-etas changed the title Add unit tests for watchdog in ProcessGroupManager Add unit tests for watchdog in ProcessGroupManager Aug 10, 2026
@cameron-craig-etas
cameron-craig-etas force-pushed the feature/add-watchdog-tests-for-process-group-manager branch from 4fbdaf0 to 65c3a7f Compare August 10, 2026 14:05
@cameron-craig-etas
cameron-craig-etas force-pushed the feature/add-watchdog-tests-for-process-group-manager branch from 65c3a7f to a03aa5b Compare August 10, 2026 14:16
@cameron-craig-etas
cameron-craig-etas force-pushed the feature/add-watchdog-tests-for-process-group-manager branch from a03aa5b to b4eb967 Compare August 10, 2026 14:43
@cameron-craig-etas
cameron-craig-etas force-pushed the feature/add-watchdog-tests-for-process-group-manager branch from 6418b15 to da1102d Compare August 11, 2026 07:07
@cameron-craig-etas
cameron-craig-etas force-pushed the feature/add-watchdog-tests-for-process-group-manager branch from da1102d to e61a411 Compare August 11, 2026 07:11
@cameron-craig-etas
cameron-craig-etas marked this pull request as ready for review August 11, 2026 07:38
Cameron Craig added 5 commits August 11, 2026 11:02
Cameron Craig
feat: Add mocks and stubs for process group manager tests
94a38b6
Cameron Craig
test: Add unit tests for ProcessGroupManager watchdog
15fc057
Cameron Craig
chore: Fix minor review issues
34925d0 
fix: Re-add missing bazel rule for watchdog factory

fix: use lm_cc_test rule

chore: Fix minor review issues
- Unused include
- Unused bazel dep
- add const variable for magic number
- Reword a comment

fix: Formatting
Cameron Craig
fix: GivenMinimalConfig_ExpectWatchdogDisabled_WhenDeinitializeCalled
ff87425
Cameron Craig
refactor: use supervision control notifier
c83b4e4
@cameron-craig-etas
cameron-craig-etas force-pushed the feature/add-watchdog-tests-for-process-group-manager branch from e61a411 to c83b4e4 Compare August 11, 2026 10:29
WilliamRoebuck
WilliamRoebuck reviewed Aug 11, 2026
View reviewed changes

@WilliamRoebuck WilliamRoebuck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some nitpicks

Comment thread score/launch_manager/src/daemon/src/process_group_manager/details/BUILD Outdated
Comment thread score/launch_manager/src/daemon/src/process_group_manager/details/process_group_manager_UT.cpp Outdated
Comment thread score/launch_manager/src/daemon/src/supervision_control_client/iprocess_state_notifier_mock.hpp
@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval August 11, 2026 15:05 — with GitHub Actions Active
@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval August 11, 2026 15:05 — with GitHub Actions Active
@MaciejKaszynski
MaciejKaszynski merged commit cf29c4e into eclipse-score:main Aug 11, 2026
20 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaciejKaszynski MaciejKaszynski MaciejKaszynski approved these changes
@NicolasFussberger NicolasFussberger Awaiting requested review from NicolasFussberger NicolasFussberger is a code owner
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq is a code owner
@ramceb ramceb Awaiting requested review from ramceb ramceb is a code owner
@FScholPer FScholPer Awaiting requested review from FScholPer FScholPer is a code owner
@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@anmittag anmittag Awaiting requested review from anmittag anmittag is a code owner
+2 more reviewers
@danth danth danth approved these changes
@WilliamRoebuck WilliamRoebuck WilliamRoebuck approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

LCM - Lifecycle & Health FT
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cameron-craig-etas @danth @MaciejKaszynski @WilliamRoebuck