Extend switch_run_target test to also cover feat_req__lifecycle__process_ordering and comp_req__launch_man__launch_manager_shutdown - #442
Merged
MaciejKaszynski merged 11 commits intoAug 11, 2026
Conversation
TimoSteuerwaldETAS
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
August 10, 2026 10:44
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
August 10, 2026 10:44 — with
GitHub Actions
Waiting
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
August 10, 2026 10:44 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
August 10, 2026 12:26 — with
GitHub Actions
Waiting
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
August 10, 2026 12:26 — with
GitHub Actions
Waiting
WilliamRoebuck
suggested changes
Aug 10, 2026
WilliamRoebuck
left a comment
Contributor
There was a problem hiding this comment.
I think the test already satisfied the feature requirement and, if you agree with me on the component one, we'd just need to change the control client to wait for SIGTERM rather than requesting the "off" target
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
August 10, 2026 16:34 — with
GitHub Actions
Waiting
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
August 10, 2026 16:34 — with
GitHub Actions
Waiting
TimoSteuerwaldETAS
force-pushed
the
feature/extend_switch_run_target_test
branch
from
August 11, 2026 08:18
f8dfe16 to
2e57e7d
Compare
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
August 11, 2026 08:18 — with
GitHub Actions
Waiting
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
August 11, 2026 08:18 — with
GitHub Actions
Waiting
WilliamRoebuck
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just one minor fix
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
August 11, 2026 09:53 — with
GitHub Actions
Waiting
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
August 11, 2026 09:53 — with
GitHub Actions
Waiting
Co-authored-by: WilliamRoebuck <244554584+WilliamRoebuck@users.noreply.github.com> Signed-off-by: Timo Steuerwald <142218678+TimoSteuerwaldETAS@users.noreply.github.com>
TimoSteuerwaldETAS
force-pushed
the
feature/extend_switch_run_target_test
branch
from
August 11, 2026 09:54
f0f17fd to
b33477c
Compare
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
August 11, 2026 09:54 — with
GitHub Actions
Waiting
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
August 11, 2026 09:54 — with
GitHub Actions
Waiting
WilliamRoebuck
approved these changes
Aug 11, 2026
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
August 11, 2026 10:51 — with
GitHub Actions
Waiting
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
August 11, 2026 10:51 — with
GitHub Actions
Waiting
MaciejKaszynski
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #317
Extends text to verify correct shutdown order.