Clarify TrustListManager lifecycle - #1837
Merged
Merged
Conversation
Document application-level ownership and close file-based managers during application shutdown so their watcher resources are released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TrustListManageras an application-owned, shared resourceFileBasedTrustListManagerMotivation
FileBasedTrustListManagerstarts a background watcher thread, but the API and examples did not make its ownership or cleanup requirements clear. An OPC UA application should share one manager and close it during application shutdown rather than tying its lifetime to an individual connection.Closes #1836
Validation
mise exec -- mvn -q spotless:applymise exec -- mvn -q clean compile