JavaClasspathTab.isDefaultClasspath fix for issue #979 - #987
Merged
Conversation
Member
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes issue #979 by comparing default classpaths against the UI’s de-duplicated model.
Changes:
- Refactors classpath model creation to return a model.
- Uses de-duplicated entries for default detection.
- Adds regression tests and suite registration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
JavaClasspathTab.java |
Updates default classpath comparison. |
JavaClasspathTabTests.java |
Adds default and custom classpath tests. |
AutomatedSuite.java |
Registers the new tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
@Greunlis : could you please squash all commits to one and force push? |
exported/not-exported ClassPathEntry eclipse-jdt#979 Fix default classpath detection by comparing against the de-duplicated UI model instead of raw entries. Fixes eclipse-jdt#979 Fix fModel initialization. Fix javadoc Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jakub Holotík <jholotik@ais.cz>
SougandhS
approved these changes
Aug 30, 2026
Member
|
Thanks @Greunlis ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix default classpath detection by comparing against the de-duplicated UI model instead of raw entries.
Fixes #979
JavaClasspathTabTests is included.