fix(web): allow deploy-skew recovery reload in private browsing - #1883
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
The Sentry GitHub App installation for this repository is missing permissions it needs to keep iterating on this pull request to get CI passing. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/ecency/settings/installations/55166181/permissions/update |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
reloadForSkewfunction inServiceWorkerRecoverypreviously returned early whensessionStoragewas unavailable (e.g., in private browsing mode or due to storage quota issues). This prevented the intended deploy-skew recovery reload, leaving users on a broken page displayingTypeError: Cannot read properties of undefined (reading 'call').This change introduces a module-level
reloadScheduledflag to handle in-page deduplication of reload requests. With this flag in place,window.location.reload()can now proceed even ifsessionStoragefails. A hard reload reinitializes the module, resetting thereloadScheduledflag, which prevents any risk of an infinite reload loop.This ensures that users in private browsing mode or those encountering
sessionStorageissues will now receive the necessary page reload to recover from deploy-skew errors, improving resilience and user experience.Fixes ECENCY-NEXT-1FN3
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.