Add validateOnStaleSecs to validate idle connections on borrow - #163
Merged
Merged
Conversation
Introduce a new `validateOnStaleSecs` option controlling the maximum idle age (in seconds) after which a free connection is validated when borrowed from the pool. This is separate from the background heartbeat and catches connections that died between heartbeat cycles before they are handed to the application. Behaviour of validateStaleMillis(): - Explicit validateOnStaleSecs is honoured; 0 disables borrow-time validation. - When unset and the heartbeat is enabled, stale-on-borrow validation remains disabled (unchanged default behaviour). - When unset and the heartbeat is disabled (e.g. AWS Lambda), it defaults to min(100, maxInactiveTimeSecs) seconds instead of the previous maxInactiveTimeSecs + trimPoolFreqSecs. Wires the setting through DataSourceBuilder, DataSourceConfig (copy, setDefaults merge, and properties load) and adds tests. Documents the option in the configuration reference, create-datasource-pool and connection-validation-best-practices guides, and the README Lambda section.
rob-bygrave
commented
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new
validateOnStaleSecsoption controlling the maximum idle age (in seconds) after which a free connection is validated when borrowed from the pool. This is separate from the background heartbeat and catches connections that died between heartbeat cycles before they are handed to the application.Behaviour of validateStaleMillis():
Wires the setting through DataSourceBuilder, DataSourceConfig (copy, setDefaults merge, and properties load) and adds tests. Documents the option in the configuration reference, create-datasource-pool and connection-validation-best-practices guides, and the README Lambda section.