Avoid implicit conversion to double#283
Open
hpjansson wants to merge 1 commit into
Open
Conversation
swilmet
approved these changes
May 23, 2026
|
|
||
| /* up and z_axis are parallel */ | ||
| if (fabs (graphene_simd4f_get_z (up) - 1.0) < FLT_EPSILON) | ||
| if (fabsf (graphene_simd4f_get_z (up) - 1.f) < FLT_EPSILON) |
There was a problem hiding this comment.
Looks all good and it's still readable. (I'm not a maintainer, but I'm doing a review to help getting this merged).
Everything is float after the change:
graphene_simd4f_get_z()returns a float.1.fis float.fabsf()takes a float argument and returns a float.FLT_EPSILONis afloat.
Tested the patch, it fixes all the warnings that I had (using clang).
I think it would be nice to add an automated/regression test (just for the public #include <graphene.h>, not for all the *.c files).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.