Reduce Psalm analysis cost for activities#401
Closed
rmcdaniel wants to merge 1 commit into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #401 +/- ##
=============================================
- Coverage 100.00% 99.73% -0.27%
- Complexity 666 683 +17
=============================================
Files 63 64 +1
Lines 2267 2299 +32
=============================================
+ Hits 2267 2293 +26
- Misses 0 6 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #399.
This refactor reduces Psalm's analysis cost for Laravel Durable Activities by:
Illuminate\Routing\ResolvesRouteDependencieswith a local resolver implementation.ActivityWithWebhookSupporttrait so the baseActivityclass stays lean.Validation:
composer ecscomposer stanphpunitactivity coverage was attempted, but the local container is missing the SQLite PDO driver required by the testbench database setup.