Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Webhooks.php
Original file line number Diff line number Diff line change
Expand Up @@ -95,18 +95,19 @@ private static function registerSignalWebhooks($workflow, $basePath)
foreach (self::getSignalMethods($workflow) as $method) {
if (self::hasWebhookAttributeOnMethod($method)) {
$slug = Str::kebab(class_basename($workflow));
$signal = Str::kebab($method->getName());
$signalMethod = $method->getName();
$signal = Str::kebab($signalMethod);
Route::post(
"{$basePath}/signal/{$slug}/{workflowId}/{$signal}",
static function (Request $request, $workflowId) use ($workflow, $method) {
static function (Request $request, $workflowId) use ($workflow, $signalMethod) {
$request = self::validateAuth($request);
$workflowInstance = WorkflowStub::load($workflowId);
$params = self::resolveNamedParameters(
$workflow,
$method->getName(),
$signalMethod,
$request->except('workflowId')
);
$workflowInstance->{$method->getName()}(...$params);
$workflowInstance->{$signalMethod}(...$params);
return response()->json([
'message' => 'Signal sent',
]);
Expand Down
20 changes: 20 additions & 0 deletions tests/Unit/WebhooksTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,26 @@ public function testSignalUnauthorized(): void
'message' => 'Unauthorized',
]);
}

public function testWebhookRoutesCanBeSerializedForRouteCaching()
{
$webhookRoutes = [];

foreach (Route::getRoutes() as $route) {
if (str_starts_with((string) $route->getName(), 'workflows.')) {
$webhookRoutes[] = $route;
}
}

$this->assertNotEmpty($webhookRoutes);

foreach ($webhookRoutes as $route) {
// Mirrors what `php artisan route:cache` does. Closures must only
// capture serializable values (no ReflectionMethod instances).
$route->prepareForSerialization();
serialize($route);
}
}
}

class TestClass
Expand Down
Loading