Add an option to disable CA certificate pinning#35
Merged
Conversation
Allows callers to opt out of CA certificate pinning while keeping TLS verification active via the OS trust store. This is a safety valve for customers who cannot upgrade when a cert chain change breaks pinning. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AaronAtDuo
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
disable_ca_pinning=Falseparameter toClient.__init__()DuoExceptionif bothdisable_ca_pinning=Trueand customduo_certsare providedverify=Trueonrequests.post()calls (OS trust store) instead ofverify=DEFAULT_CA_CERT_PATH(bundled CA bundle)How Has This Been Tested?
TestDisableCaPinning— 7 tests verifying constructor behavior:Falseand uses bundled CA certsTruewith default orNoneduo_certsTruewith explicitDEFAULT_CA_CERT_PATHduo_certsDuoExceptionwhen combined with a customduo_certspathDuoExceptionwhen combined withduo_certs='DISABLE'Falsepreserves existing behaviorTestDisableCaPinningRequests— 4 tests verifying request behavior:verify=True(system trust store)verify=DEFAULT_CA_CERT_PATH(bundled)verify=True(system trust store)verify=DEFAULT_CA_CERT_PATH(bundled)Types of Changes