Skip to content

Improve replicated gateway display in older CLIs #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvstme merged 1 commit into from
Jun 17, 2026
Merged

Improve replicated gateway display in older CLIs #3975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dstack/_internal/server/compatibility/gateways.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
def patch_gateway(gateway: Gateway, client_version: Optional[Version]) -> None:
if client_version is None:
return
if client_version < Version("0.20.25") and len(gateway.replicas) < 2:
if client_version < Version("0.20.25"):
gateway.instance_id = ""
gateway.ip_address = gateway.replicas[0].hostname if gateway.replicas else ""
gateway.ip_address = "\n".join(r.hostname for r in gateway.replicas)
if gateway.hostname is None:
gateway.hostname = gateway.ip_address
7 changes: 4 additions & 3 deletions src/tests/_internal/server/compatibility/test_gateways.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,10 @@ def test_old_version_no_replicas_sets_empty_strings(self):
assert gw.instance_id == ""
assert gw.hostname == ""

def test_old_version_multi_replica_is_noop(self):
def test_old_version_multi_replica_concatenates_hostnames(self):
replicas = [_make_gateway_replica("1.2.3.4"), _make_gateway_replica("5.6.7.8")]
gw = _make_gateway(replicas=replicas)
patch_gateway(gw, Version("0.20.24"))
assert gw.ip_address is None
assert gw.instance_id is None
assert gw.hostname == "1.2.3.4\n5.6.7.8"
assert gw.ip_address == "1.2.3.4\n5.6.7.8"
assert gw.instance_id == ""
Loading