fix(367): nullable remediation for UtilitiesCS/NewtonsoftHelpers (per-file #nullable enable)

[drmoisan]

Nullable-reference-type remediation for UtilitiesCS/NewtonsoftHelpers (per-file #nullable enable)

Epic child of utilitiescs-nullable-remediation (Wave 0). Base branch: epic/utilitiescs-nullable-remediation-integration.

Summary

• Opt each of the 19 production .cs files under UtilitiesCS/NewtonsoftHelpers/ (root plus MonoExtension/ and SDIL Reader/) into a per-file #nullable enable pragma and drive each file to zero CS86xx nullable diagnostics.
• Annotation and null-safety only: ? annotations, null guards, null-forgiving ! where justified, and null-flow corrections. No behavior change, no refactor, no API redesign, no file splits.
• No project-level or solution-level <Nullable> element is introduced; UtilitiesCS.csproj keeps none.
• Newtonsoft.Json JsonConverter / ISerializationBinder / ITraceWriter override signatures are matched to their framework-defined nullability rather than changed.
• Diff scope: 19 .cs files, +198 / -112. No .csproj, .sln, packages.config, SVGControl/**, or .claude/rules/* change.

Why

The CI nullable gate (repaired by PR #361 to run a genuine /t:Rebuild recompile) now surfaces pre-existing CS86xx diagnostics that were previously masked. The UtilitiesCS/NewtonsoftHelpers/ tree carries such pre-existing nullable debt in custom Newtonsoft.Json converters, serialization binders, trace writers, dictionary wrapper converters, and the SDIL Reader IL-parsing helpers. These are serialization helpers consumed across module boundaries (ReusableTypes, OutlookObjects/Store, EmailIntelligence, and app-globals consumers); their nullability annotations become contracts those callers depend on. Remediating per-file keeps this child independently mergeable without force-enabling nullable epic-wide.

What Changed

• Converters / binders / trace writers / wrappers (19 files): AllInclusiveBinder, AppGlobalsConverter, DerivedCompositionConverter_ConcurrentDictionary, FilePathHelperConverter, KnownTypesBinder, MonoExtension/MonoExtension, NConsoleTraceWriter, NLogTraceWriter, NonRecursiveConverter, PeopleScoConverter, PeopleScoRemainingObjectConverter, SDIL Reader/ILGlobals, SDIL Reader/ILInstruction, SDIL Reader/MethodBodyReader, ScDictionaryConverter, ScoDictionaryConverter, WrapperPeopleScoDictionaryNew, WrapperScDictionary, WrapperScoDictionary.
• Framework signature matching: nullable positions annotated (existingValue, value, converter ReadJson returns, BindToType assemblyName, BindToName out string?, Trace Exception? ex); non-null positions preserved (serializer, reader, writer, objectType, serializedType, typeName, message).
• Pragma normalization: NonRecursiveConverter.cs mid-file pragma moved to the top of the file; NLogTraceWriter.cs GLOBAL namespace preserved (annotated in place).
• Docs / evidence: feature spec, user-story, and plan AC check-offs plus baseline, qa-gate, and regression-testing evidence artifacts under the feature folder.

Verification

Completed (see evidence/qa-gates/ and evidence/regression-testing/):

• Format: dotnet csharpier check . — clean (1406 files).
• Analyzers/codestyle: msbuild TaskMaster.sln /t:Build /p:EnableNETAnalyzers=true /p:EnforceCodeStyleInBuild=true — 0 errors, 0 new diagnostics in NewtonsoftHelpers (only pre-existing test-project warnings).
• Nullable gate (per-file pragma, project-level UtilitiesCS.csproj /t:Rebuild /p:TreatWarningsAsErrors=true exempting only pre-existing non-nullable CS0649/CS0618/CS0168) — zero CS86xx across all 19 opted-in files.
• Tests: 4511 passed, 0 failed.
• Coverage: no regression on changed lines; NewtonsoftHelpers targeted line-rate 93.71% -> 93.81%; UtilitiesCS.Test-scope overall 72.07% unchanged.
• Feature-review: PASS, blocking_count = 0; all 16 acceptance criteria verified.

Note on the solution-level nullable command: msbuild TaskMaster.sln /t:Rebuild /p:TreatWarningsAsErrors=true exits 1 solely on 2 pre-existing vendored SVGControl/SvgImageSelector.cs CS0649 (unused-field) warnings that exist identically on origin/main, are non-nullable, and are out of scope for this child (that file is untouched). The project-level gate above is the authoritative nullable proof.

Backward Compatibility / Migration Notes

• No breaking changes. Annotations reflect actual runtime null behavior and are additive contracts for downstream serialization/persistence callers.
• No public signature changes beyond nullability annotation; framework override signatures are matched, not altered.

Risks and Mitigations

• Risk: an over-tight annotation could propagate an incorrect null assumption to callers. Mitigation: annotations were matched to observed runtime behavior and the Newtonsoft.Json framework signatures; full test suite (4511) passes with no assertion changes.
• Risk: three wrapper files remain above the 500-line limit (WrapperScoDictionary.cs 649, WrapperPeopleScoDictionaryNew.cs 615, WrapperScDictionary.cs 524). This is a pre-existing condition; splitting is out of scope for annotation-only work and is flagged to the maintainer, not fixed here.

Review Guide

• The 19 .cs diffs are uniformly annotation-only; review the converter override signatures first (AppGlobalsConverter, ScDictionaryConverter, ScoDictionaryConverter, PeopleScoConverter, FilePathHelperConverter) for framework-signature fidelity, then the reflection-heavy wrappers and SDIL Reader for the behavior-preserving ! sites.
• Evidence artifacts under the feature folder document each batch's nullable build and test run.

Follow-ups

• Epic capstone child resolves the rules-vs-convention conflict (.claude/rules/csharp.md documents forcing /p:Nullable=enable globally vs the per-file opt-in convention) and the pre-existing >500-line wrapper split.

GitHub Auto-close

• Closes Feature: utilitiescs-nullable-newtonsofthelpers #367