chore(memory): salvage uncommitted agent-memory and #317 audit artifacts from stale worktrees

[drmoisan]

chore(memory): salvage uncommitted agent-memory and #317 audit artifacts from stale worktrees

Summary

• Recovers 15 files of agent-memory and audit-trail evidence that were left uncommitted in completed, merged worktrees before those worktrees are deleted.
• Adds the three timestamped feature-review audit artifacts (policy-audit, code-review, feature-audit, all 2026-07-11T22-30) for collection-lock-recursion-coverage-317, which were authored in the feature worktree but never committed.
• Adds six new agent-memory notes (feature-review x2, atomic-planner x1, task-researcher x1, orchestrator x1, atomic-executor x1) and their index entries, recovered from seven .claude/worktrees/agent-* worktree locations and the feature/store-disable-service-261 branch.
• Extends orchestrator-state-validator-divergence.md with a confirmed finding about --require-complete behavior on resumed epic-child checkpoints (Feature: swordfish-raw-usage-cleanup #310 run).
• No production code, test code, or build configuration is changed.

Why

Worktree cleanup found these files present only in worktrees whose branches are fully merged. The repository convention is that all audit-trail evidence and agent-memory must be committed; deleting the worktrees without this salvage would have discarded the content permanently.

What Changed

• Docs (audit artifacts for Re-express lock-recursion regression coverage against the clean ConcurrentObservableCollection base #317):
  • docs/features/active/collection-lock-recursion-coverage-317/policy-audit.2026-07-11T22-30.md (+145)
  • docs/features/active/collection-lock-recursion-coverage-317/code-review.2026-07-11T22-30.md (+57)
  • docs/features/active/collection-lock-recursion-coverage-317/feature-audit.2026-07-11T22-30.md (+54)
• Agent memory (new notes + index updates):
  • feature-review: ScoDictionaryNew enumeration-order/removal-API note; epic-child two-dot diff divergence note
  • atomic-planner: Feature: efcviewer-breadcrumb-webview2 #349 breadcrumb plan seams note
  • task-researcher: Feature: efcviewer-breadcrumb-webview2 #349 EfcViewer breadcrumb WebView2 note
  • orchestrator: epic-child PR-gate gotchas note; validator-divergence addendum
  • atomic-executor: Refactor: taskvisualization-secondary-testability #298 TaskVisualization ScoCollection/live-bridge exemption note (recovered from an orphaned, unregistered worktree directory)

Architecture / How It Fits Together

Not applicable — documentation and agent-memory only; no runtime components are affected.

Verification

• Completed: the Re-express lock-recursion regression coverage against the clean ConcurrentObservableCollection base #317 feature evidence in context records passing restore/build/test gates for the underlying feature (see evidence/ files dated 2026-07-11); those gates predate this PR and are unchanged by it.
• This PR itself contains no code, so no toolchain run is required. Not verified in this PR beyond git status cleanliness of the salvage commit.
• Recommended: none.

Backward Compatibility / Migration Notes

None. Additive documentation and memory files only.

Risks and Mitigations

• Risk: memory index entries could duplicate existing entries. Mitigation: each new note was verified absent from main (git cat-file -e) before inclusion; index conflicts were resolved by keeping both sides.
• Rollback: revert the single commit.

Review Guide

1. docs/features/active/collection-lock-recursion-coverage-317/*.2026-07-11T22-30.md — audit artifacts, largest files.
2. .claude/agent-memory/** — six new notes plus six index/addendum edits.

Follow-ups

• Delete the now-redundant worktrees and merged branches (performed in the same cleanup session after this PR merges).

GitHub Auto-close

• None