Require at least c#dk version 11 if installed

[Copilot]

Breaking compatibility changes require C# Dev Kit v11 when both extensions are active. Users with an older Dev Kit version should install the v11 prerelease or switch to the release C# extension.

• Compatibility guard

  • Check the installed C# Dev Kit major version during activation.
  • Allow standalone C# usage and Dev Kit v11 prereleases.
  • Stop activation for older versions with actionable guidance.

• Coverage

  • Cover missing, compatible, future, prerelease, and incompatible Dev Kit versions.

[dibarbet]

@copilot please also bump the main version number to 11.1 as well

[Copilot]

@copilot please also bump the main version number to 11.1 as well

Updated the minimum required C# Dev Kit version to 11.1 in 2b55f23, including the user message, localization bundle, and boundary tests.

[Copilot]

🟡 Changes recommended

Critical test, fixture, and version metadata issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds an activation-time compatibility guard requiring C# Dev Kit 11 or later when both extensions are active.

Changes:

• Adds version validation and localized guidance.
• Runs the guard during activation.
• Adds unit coverage and updates version metadata.

File summaries

File	Summary	Review notes
version.json	Updates extension version metadata.	Revert the unintended 11.1 version change.
test/lsptoolshost/unitTests/checkCSharpDevKitVersion.test.ts	Tests Dev Kit compatibility scenarios.	Align the expected message with the implementation.
src/main.ts	Runs validation during activation.	—
src/checkCSharpDevKitVersion.ts	Implements Dev Kit version validation.	Align the integration-test Dev Kit fixture with the required version.
l10n/bundle.l10n.json	Adds localized compatibility guidance.	—

Review details

• Files reviewed: 5/5 changed files
• Comments generated: 3
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

The localization key does not match the source string, leaving the new error untranslated.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (1)

l10n/bundle.l10n.json:8

• This bundle entry does not match the string passed to vscode.l10n.t in checkCSharpDevKitVersion.ts, so the new error cannot resolve through the localization bundle and this entry remains unused. Replace the key/value with the shorter message currently used by the implementation (and asserted by the unit test).

  "This version of the C# extension requires C# Dev Kit version 11 or later. Please install the latest pre-release version of C# Dev Kit or use the release version of the C# extension.": "This version of the C# extension requires C# Dev Kit version 11 or later. Please install the latest pre-release version of C# Dev Kit or use the release version of the C# extension.",

• Files reviewed: 9/9 changed files
• Comments generated: 1
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

Fix the version metadata, extension-opening command, and incomplete recovery guidance before approval.

Review details

Suppressed comments (4)

CHANGELOG.md:7

• The active changelog section is being renamed from 2.152.x to 11.1.x even though this repository's release notes use the 2..x scheme. This would put the new entry under a version that does not match the extension's release automation; restore the existing heading and let the normal snap process create/update release sections.

# 11.1.x
* Require C# Dev Kit version 11 or later (PR: [#9776](https://github.com/dotnet/vscode-csharp/pull/9776))

src/checkCSharpDevKitVersion.ts:29

• extension.open is not the VS Code command for opening an installed extension. If the user selects this button, executeCommand rejects and the activation failure is reported instead of opening the Dev Kit page. Use the built-in workbench.extensions.action.showExtensionsWithIds command with the Dev Kit ID (and update the corresponding unit-test expectation).

        await vscode.commands.executeCommand('extension.open', csharpDevkitExtensionId);

src/checkCSharpDevKitVersion.ts:25

• The PR description says users with an older Dev Kit can either install the v11 prerelease or switch to the release C# extension, but this message only offers the prerelease Dev Kit path. Please include the release-extension alternative so users who cannot upgrade Dev Kit receive the documented recovery option; update the generated localization bundle with the same key as well.

    const message = vscode.l10n.t(
        'C# Dev Kit version 11 or later is required. Please switch to the pre-release version of the C# Dev Kit.'
    );

version.json:3

• This changes the packaged C# extension version from the repository's established 2.x release train to 11.1. The documented scheme uses 2..x versions, and feature PRs leave version.json for the branch-snap workflow; shipping this would produce an incorrectly versioned extension. Please revert this edit and let the release automation update the version.

    "version": "11.1",

• Files reviewed: 9/9 changed files
• Comments generated: 0 new
• Review effort level: Lite

[dibarbet]

@copilot please skip the source link integration tests - there is a bug in C#DK v11

[Copilot]

@copilot please skip the source link integration tests - there is a bug in C#DK v11

Skipped both Source Link integration tests in fc7c3df; the skips are documented with their C# Dev Kit v11 re-enable condition in subsequent commits.

[Copilot]

🔵 Needs a closer look

Address the versioning concern and expand the incompatible-version guidance.

Review details

Suppressed comments (2)

src/checkCSharpDevKitVersion.ts:25

• For an older Dev Kit, this modal only offers the prerelease path, while the PR description also promises a release C# fallback. The documented standalone path is to disable Dev Kit or enable dotnet.preferCSharpExtension; mention that alternative in this error so users who cannot install the prerelease have an actionable way to recover.

    const message = vscode.l10n.t(
        'C# Dev Kit version 11 or later is required. Please switch to the pre-release version of the C# Dev Kit.'
    );

version.json:3

• This changes the C# extension package from 2.152 to 11.1, although the compatibility requirement is for the separate C# Dev Kit extension. The repository's versioning scheme keeps prereleases on standard 2.x minor increments (CONTRIBUTING.md:192-196), and the branch-snap workflow owns version.json updates (azure-pipelines.yml:46-47; .github/workflows/branch-snap.yml:34-40). Please leave the extension version and matching changelog section to the normal release automation, or update the documented release process separately if an extension-major migration is intended.

    "version": "11.1",

• Files reviewed: 10/10 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

Copilot review overview

🟡 Changes recommended

Unresolved moderate issues affect activation behavior, CI coverage, test coverage, and release metadata.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2

Open (2)

• CI no longer runs the DevKitTests suite · New
• The string passed to vscode.l10n.t here does not match the key added in l10n/bundle.l10n.json:…

Previously missed (1)

In code that hasn't changed since last review

Keep changelog release heading at 2.152.x

CHANGELOG.md:6

This renames the current release-notes section from 2.152.x to 11.1.x, so the changelog no longer matches the repository's documented release-version scheme or the version that this feature branch started from. Keep the existing 2.152.x heading; release automation should create any new version section.