Average gcperfsim results#5233
Open
VincentBu wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR refactors the GC infrastructure benchmark tooling, consolidating the Run/CoreRunInfo types into a unified CoreRunInfo hierarchy, restructures the GCPerfSim analysis pipeline into separate analyze/present phases, and improves NaN handling in report output.
Changes:
- Unifies configuration types around a new
CoreRunInfoBaseand marks many configuration properties asrequired. - Refactors
GCPerfSimAnalyzeCommandintoExecuteAnalysis+Present, and rewrites the markdown generator to operate on groupedGCTraceMetricComparisonResults. - Removes per-scenario factory methods (
CreateNormalServerCase,CreateHighMemoryCase, etc.) and consolidates suite creation throughGetBaseGCPerfsimSuite.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| RunCommand.cs | Flattens nested analysis results and adds NaN-safe percentage formatting. |
| CreateSuiteCommand.cs | Renames base configuration builder, populates corerun dictionaries explicitly, removes scenario factory methods. |
| MicrobenchmarkCommand.cs | Updates Run references to CoreRunInfo. |
| GCPerfSimCommand.cs | Splits analysis from presentation; renames Iterations to iterations. |
| GCPerfSimAnalyzeCommand.cs | Introduces separate ExecuteAnalysis and Present methods over the new comparison types. |
| Presentation/GCPerfSim/Markdown.cs | Rewrites analyze-command markdown generation in terms of grouped comparison results. |
| Presentation/GCPerfSim/Json.cs | Adds GenerateForAnalyzeCommand serialization helper. |
| Microbenchmarks.Configuration.cs | Replaces Run with CoreRunInfo (with commented-out old class). |
| InputConfiguration.cs | Marks fields required, switches dictionaries to CoreRunInfoBase. |
| GCPerfSimFunctional.Configuration.cs | Marks fields required, removes unused usings. |
| GCPerfSim.Configuration.cs | Adds nested CoreRunInfo, renames Iterations → iterations, marks fields required. |
| ConfigurationBase.cs | Marks fields required, introduces CoreRunInfoBase. |
| Common.cs | Removes old CoreRunInfo class. |
| Microbenchmark.CommandBuilder.cs | Uses Path instead of corerun. |
| MicrobenchmarkResultComparison.cs | Updates tuple generic args to CoreRunInfo. |
| MicrobenchmarkResult.cs | Updates Parent type to CoreRunInfo. |
| GCTraceMetrics.cs | Adds optional Parent CoreRunInfo property. |
| GCTraceMetricComparisonResults.cs | New grouping/classification type for comparison results. |
| GCTraceMetricComparison.cs | Adds full pipeline: trace file discovery, analysis, comparison, grouping. |
| Run.yaml | Adds gcperfsim: 1 iteration entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at calculating average value of multiple gcperfsim tests results.