Skip to content

Clarify that Include requires navigation property access #39189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndriySvyryd merged 2 commits into from
Oct 13, 2026
+38 −2
Merged

Clarify that Include requires navigation property access #39189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
608ff81
Clarify that Include requires navigation property access (#33018)
SkyDevLab Oct 7, 2026
17944c3
Add provider test overrides for Include_complex_property
SkyDevLab Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EFCore/Properties/CoreStrings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/EFCore/Properties/CoreStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,7 @@
<value>The value '{value}' provided for argument '{argumentName}' must be a valid value of enum type '{enumType}'.</value>
</data>
<data name="InvalidIncludeExpression" xml:space="preserve">
<value>The expression '{expression}' is invalid inside an 'Include' operation, since it does not represent a property access: 't =&gt; t.MyProperty'. To target navigations declared on derived types, use casting ('t =&gt; ((Derived)t).MyProperty') or the 'as' operator ('t =&gt; (t as Derived).MyProperty'). Collection navigation access can be filtered by composing Where, OrderBy(Descending), ThenBy(Descending), Skip or Take operations. For more information on including related data, see https://go.microsoft.com/fwlink/?LinkID=746393.</value>
<value>The expression '{expression}' is invalid inside an 'Include' operation, since it does not represent a navigation property access: 't =&gt; t.MyProperty'. To target navigations declared on derived types, use casting ('t =&gt; ((Derived)t).MyProperty') or the 'as' operator ('t =&gt; (t as Derived).MyProperty'). Collection navigation access can be filtered by composing Where, OrderBy(Descending), ThenBy(Descending), Skip or Take operations. For more information on including related data, see https://go.microsoft.com/fwlink/?LinkID=746393.</value>
</data>
<data name="InvalidKeyValue" xml:space="preserve">
<value>Unable to track an entity of type '{entityType}' because its primary key property '{keyProperty}' is null.</value>
Expand Down
7 changes: 7 additions & 0 deletions test/EFCore.Cosmos.FunctionalTests/Query/ComplexTypeQueryCosmosTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,13 @@ FROM root c
""");
});

public override async Task Include_complex_property(bool async)
{
await base.Include_complex_property(async);

AssertSql();
}

public override Task Complex_type_equals_complex_type(bool async)
=> CosmosTestHelpers.Instance.NoSyncTest(
async, async async =>
Expand Down
7 changes: 7 additions & 0 deletions test/EFCore.Cosmos.FunctionalTests/Query/ComplexTypeToJsonPropertyQueryCosmosTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,13 @@ FROM root c
""");
});

public override async Task Include_complex_property(bool async)
{
await base.Include_complex_property(async);

AssertSql();
}

public override Task Complex_type_equals_complex_type(bool async)
=> CosmosTestHelpers.Instance.NoSyncTest(
async, async async =>
Expand Down
8 changes: 8 additions & 0 deletions test/EFCore.Specification.Tests/Query/ComplexTypeQueryTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,14 @@ public virtual Task Select_complex_type_Distinct(bool async)
async,
ss => ss.Set<Customer>().Select(c => c.ShippingAddress).Distinct());

[Theory, MemberData(nameof(IsAsyncData))]
public virtual async Task Include_complex_property(bool async)
=> Assert.Equal(
CoreStrings.InvalidIncludeExpression("c.ShippingAddress"),
(await Assert.ThrowsAsync<InvalidOperationException>(() => AssertQuery(
Comment thread
AndriySvyryd marked this conversation as resolved.
async,
ss => ss.Set<Customer>().Include(c => c.ShippingAddress)))).Message);

[Theory, MemberData(nameof(IsAsyncData))]
public virtual Task Complex_type_equals_complex_type(bool async)
=> AssertQuery(
Expand Down
7 changes: 7 additions & 0 deletions test/EFCore.SqlServer.FunctionalTests/Query/ComplexTypeQuerySqlServerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,13 @@ FROM [Customer] AS [c]
""");
}

public override async Task Include_complex_property(bool async)
{
await base.Include_complex_property(async);

AssertSql();
}

public override async Task Complex_type_equals_complex_type(bool async)
{
await base.Complex_type_equals_complex_type(async);
Expand Down
7 changes: 7 additions & 0 deletions test/EFCore.Sqlite.FunctionalTests/Query/ComplexTypeQuerySqliteTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,13 @@ public override async Task Select_complex_type_Distinct(bool async)
""");
}

public override async Task Include_complex_property(bool async)
{
await base.Include_complex_property(async);

AssertSql();
}

public override async Task Complex_type_equals_complex_type(bool async)
{
await base.Complex_type_equals_complex_type(async);
Expand Down
Loading