Fix mock file stream truncation and strengthen XHarness path assertions - #17597
Open
akoeplinger wants to merge 1 commit into
Open
akoeplinger wants to merge 1 commit into
akoeplinger wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 208e5355-ef64-4625-8d0c-2c153e134dfa
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Fix append-mode positioning and add committed regression coverage for the mock stream behavior.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Fixes mock file stream truncation and strengthens XHarness archive path assertions.
Changes:
- Adds mode-aware, expandable mock streams while preserving embedded NUL characters.
- Adds exact archive destination and metadata assertions.
| File | Changes |
|---|---|
src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/CreateXHarnessAppleWorkItemsTests.cs |
Adds exact Apple archive-path assertions. |
src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/CreateXHarnessAndroidWorkItemsTests.cs |
Adds exact Android archive-path assertions. |
src/Common/Microsoft.Arcade.Test.Common/MockFileSystem.cs |
Updates mock stream initialization and persistence behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #17571: fix mock stream truncation and expansion, preserve NUL characters, and assert exact XHarness archive paths.
Validation: Helix SDK tests passed. Full Release validation failed in the central-package-management and SignTool tests, outside this patch.